Skip to content

Add conda-forge channel to the 2.x build image #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2017

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 16, 2017

Closes readthedocs/readthedocs.org#2713

If this is something we want, I will make another PR to do the same in the latest build image.

We need some testing for this, also.

@humitos humitos added the PR: work in progress Pull request is not ready for full review label Mar 16, 2017
@humitos humitos changed the base branch from master to 2.x-upgrade March 16, 2017 22:09
@humitos
Copy link
Member Author

humitos commented Mar 16, 2017

On the other hand, I'm thinking if this is something that we want to do in the image or as a build command every time a RTD project builds.

@willingc
Copy link

@humitos Here's a link to the docker-stacks that we use in Jupyter and how we handle conda and conda-forge channel https://github.com/jupyter/docker-stacks/blob/master/base-notebook/Dockerfile#L66

@humitos
Copy link
Member Author

humitos commented Mar 16, 2017

@willingc great!

The only difference that I see is the --system that in RTD specific case I think won't change too much since the all the commands inside the docker image are ran by the docs user, but anyway I think we should use it :)

@ericholscher
Copy link
Member

+1 Thanks @willingc -- Looks like we should steal the no auto upgrade bit too?

@humitos
Copy link
Member Author

humitos commented Mar 16, 2017

@ericholscher if we really want to have a pinned version, we should... otherwise it will upgrade on every conda env create

Read this: readthedocs/readthedocs.org#2566 (comment)

@willingc
Copy link

I would seriously consider readthedocs/readthedocs.org#2566 (comment) from @SylvainCorlay.

@ericholscher ericholscher changed the base branch from 2.x-upgrade to releases/2.x March 17, 2017 17:34
@ericholscher
Copy link
Member

@humitos This should be targeting the release-2.x branch, I believe. I've gone ahead and updated it.

@ericholscher ericholscher force-pushed the humitos/conda/conda-forge-channel branch from a1cc85e to 99bd955 Compare March 17, 2017 17:35
@ericholscher ericholscher merged commit ff94234 into releases/2.x Mar 20, 2017
@ericholscher ericholscher removed the PR: work in progress Pull request is not ready for full review label Mar 20, 2017
@ericholscher
Copy link
Member

Gonna call this done, and merge it. We can track removing our version overrides for conda separately.

@humitos humitos deleted the humitos/conda/conda-forge-channel branch September 3, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants