-
Notifications
You must be signed in to change notification settings - Fork 70
Add conda-forge channel to the 2.x build image #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On the other hand, I'm thinking if this is something that we want to do in the image or as a build command every time a RTD project builds. |
@humitos Here's a link to the docker-stacks that we use in Jupyter and how we handle conda and conda-forge channel https://github.com/jupyter/docker-stacks/blob/master/base-notebook/Dockerfile#L66 |
@willingc great! The only difference that I see is the |
+1 Thanks @willingc -- Looks like we should steal the no auto upgrade bit too? |
@ericholscher if we really want to have a pinned version, we should... otherwise it will upgrade on every Read this: readthedocs/readthedocs.org#2566 (comment) |
I would seriously consider readthedocs/readthedocs.org#2566 (comment) from @SylvainCorlay. |
@humitos This should be targeting the |
a1cc85e
to
99bd955
Compare
Gonna call this done, and merge it. We can track removing our version overrides for conda separately. |
Closes readthedocs/readthedocs.org#2713
If this is something we want, I will make another PR to do the same in the
latest
build image.We need some testing for this, also.